Rails 7.2 compatibility

paper-trail-gem / paper_trail

Track changes to your rails models

MIT License

6.79k stars 896 forks source link

Closed theodorton closed 2 months ago

theodorton commented 5 months ago

[x] Wrote good commit messages.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests. - Not relevant; refactoring to support Rails 7.2
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. - Not relevant; refactoring to support Rails 7.2
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.

fatkodima commented 4 months ago

That CI failure regarding coverage - these coverage metrics are pretty pointless imo, I would prefer to just remove it from the project.

theodorton commented 4 months ago

I've fixed the compatibility spec, added the new appraisal to the CI matrix and squashed.

arikarim commented 2 months ago

any update on this please?

theodorton commented 2 months ago

Updated appraisal to use the official Rails 7.2 release. I can't do much about the coverage metrics that @fatkodima already mentioned.

@jaredbeck Is there any more work needed from my side to get this to a mergeable state?

veganstraightedge commented 2 months ago

Hi paper trail gem folks 👋🏻 i'm adding my voice to the chorus of encouragement to merging this PR or the other one https://github.com/paper-trail-gem/paper_trail/pull/1485

kriom commented 2 months ago

Likewise, hello people from paper trail gem, I also add my voice and encouragement to merge this PR :heart_hands:

gurgelrenan commented 2 months ago

Let's focus on #1485 . I will close this P.R. @theodorton could you please check if you could improve #1485 ?