Improves readability - Githubissues

paperboi / kindle2notion

Export all clippings from your Kindle device to a database in Notion.

https://pypi.org/project/kindle2notion/

MIT License

904 stars 120 forks source link

Improves readability #20

Closed jlmbaka closed 3 years ago

jlmbaka commented 3 years ago

My goal with this PR is to increase the readability of the clippings when imported in Notion.

I made the following changes:

Removed the Bold formatting for the clipping text as I found it hard to read as formatted, especially when you have a large body of text.
I added the references (pages, location, and date) in parentheses, making it as easier to read in my opinion (inspiring myself from Readwise)

I made the following fixes:

I fixed a bug that was crashing the script when the date was not available in the Clipping.txt file: this was happening because for each highlight, we were not checking if date is None or empty, despite doing the same for other elements (clipping, page, and location).
I noticed that requirements.txt did not contain the package dateparser, despite being used in kindle2notion.py, therefore I added it.

paperboi commented 3 years ago

Thank you so much @jlmbaka for finding the bug and raising this PR. Merged it with my master branch. The readability-related additions were a nice addition too. Great job on the documentation and I hope you have a great day ahead!