paperboi / kindle2notion

Export all clippings from your Kindle device to a database in Notion.
https://pypi.org/project/kindle2notion/
MIT License
886 stars 120 forks source link

Fixes display of thumbnails fetched from Google Book API #34

Closed guptaanmol184 closed 3 years ago

guptaanmol184 commented 3 years ago

Fixes #30

Makes cover urls from google books api use https instead of http based on solution from stackoverflow: https://stackoverflow.com/questions/51773767/how-to-set-image-to-google-play-books-api-thumbnail-using-fresco

Also, makes kindle2notion package use local modules instead of using system installed kindle2notion module by fixing respective import paths.

paperboi commented 3 years ago

Fixes #30

Makes cover urls from google books api use https instead of http based on solution from stackoverflow: https://stackoverflow.com/questions/51773767/how-to-set-image-to-google-play-books-api-thumbnail-using-fresco

Also, makes kindle2notion package use local modules instead of using system installed kindle2notion module by fixing respective import paths.

Sweet! Will test this tomorrow and get back to you! Thanks for contributing to the repo!

paperboi commented 3 years ago

Can you please explain the rationale for the import path changes? Won't the compiler produce ModuleNotFound Errors without specifying import paths?