[fix_tests] - fix failing tests and close file properly after read

paperboi / kindle2notion

Export all clippings from your Kindle device to a database in Notion.

https://pypi.org/project/kindle2notion/

MIT License

903 stars 120 forks source link

[fix_tests] - fix failing tests and close file properly after read #56

Closed adam-tokarski closed 2 years ago

adam-tokarski commented 3 years ago

when file is opened by open, it's good to close it afterwards. This can be done with contextmanager.
there were failing tests because of isNote new parameter
isNote was also changed to is_note whenever it's possible
I added back some ignore statements to setup.cfg to avoid conflicts between black and flake8
also, .idea was added to .gitignore

paperboi commented 2 years ago

Hi Adam, I appreciate your suggestions and insight on the code. Thank you for raising this PR. I will approve them as soon I resolve all the branch conflicts.