search

paperclip-rs / paperclip

WIP OpenAPI tooling for Rust.
Apache License 2.0
890 stars 117 forks source link

build: update openapiv3 to v2.0 #525

Closed tiagolobocastro closed 1 week ago

tiagolobocastro commented 4 months ago

There's a breaking change on the crate which does not expose the fields as pub and so we need to use our own patch for now.

tiagolobocastro commented 4 months ago

Raised PR on openapiv3: https://github.com/glademiller/openapiv3/pull/86

tiagolobocastro commented 2 weeks ago

The raised PR is still not reviewed, I wonder if the repo is no longer maintained. So we'd have to consider forking or switching to another crate in order to make progress here and in the other PR which is depending on this one... @Sufflope @formlogic-kirk @snaggen @RaulTrombin @thomedw what are your thoughts here?

thomedw commented 2 weeks ago

Hi @tiagolobocastro,

There's a crate called openapiv3-extended, which is a fork of the repository you mentioned. It might be worth checking out.

I think it has the required pub fields https://github.com/kurtbuilds/openapiv3/blob/master/src/security_scheme.rs#L67.

tiagolobocastro commented 2 weeks ago

Hi @tiagolobocastro,

There's a crate called openapiv3-extended, which is a fork of the repository you mentioned. It might be worth checking out.

I think it has the required pub fields https://github.com/kurtbuilds/openapiv3/blob/master/src/security_scheme.rs#L67.

I did not know this, thank you! I'll take a look

tiagolobocastro commented 1 week ago

Seems like updating to the extended crate would take a few changes, and we might have to raise a PR there as well. To avoid going through this loop again, I've added a new crate, a simple fork with just these changes. Since openapiv3 is not part of the public api yet, this should be fairly harmless but we do need to consider how to progress forward.