Add horizontal scroll to coin buttons

papercliplabs / compound-info

GNU General Public License v3.0

7 stars 5 forks source link

Add horizontal scroll to coin buttons #116

Closed alexreyes closed 3 years ago

alexreyes commented 3 years ago

PR based on: issue https://github.com/papercliplabs/compound-info/issues/110. I added horizontal scroll buttons to improve usability for users without mouses with horizontal scroll wheels.

Let me know what feedback you have on design/usability/changes I should make! demo

alexreyes commented 3 years ago

Actually on second thought, I think this needs an update before it's ready to review. I need to add a change so that a scroll button gets hidden when you can't scroll in that direction more.

alexreyes commented 3 years ago

Okay, just updated it with the changes I mentioned above! @spennyp it's ready for review now :)

demo v3

spennyp commented 3 years ago

When it is all the way left it looks weird with the leftmost card (ETH) not aligned (i.e, it will look weird when it loads in). We should hide the component holding the arrow completely so it doesn't take up any width causing this offset (display=none).

spennyp commented 3 years ago

Nice!