paperize / paperize

a totally free web tool for generating board games from spreadsheets
http://paperize.io
GNU General Public License v3.0
45 stars 3 forks source link

Problems when image names conflict #125

Open Itangalo opened 2 years ago

Itangalo commented 2 years ago

Describe the bug I had two images with the same name, in different folders. I could not get paperize to pick up the one I wanted, even pointing (again) to the correct folder and also renaming the other image.

To Reproduce

  1. Upload an image foo.jpg to the image folder. Use it in a component, with dynamic image names.
  2. Create a subfolder "bar" in the Image folder. Upload another image also named foo.jpg to it.
  3. Direct the component to look for images in "bar".
  4. Result: The first foo image is still picked up.
  5. Rename the first foo image.
  6. Result: The first foo image is still picked up.
  7. Clear image cache.
  8. Result: The first foo image is still picked up.
  9. Delete the first foo image from Google Drive. Re-upload with another name.
  10. Result: The second foo image is picked up.

Expected behavior I don't really know what the expected behaviour should be here. I mean, it's a good thing that I can move around images without connections being broken. But at least when renaming images it would be nice if the connection is broken, since the connection is based on the name of the image.

lorennorman commented 2 years ago

Interesting one. Perhaps some simple image search result prioritization by weight images that have closer proximity to the game folder you're working would go a long way:

/Paperize/This Game/Images <-- use one from here...
/Paperize/Other Game/Images <-- ...before one found here

at least when renaming images it would be nice if the connection is broken, since the connection is based on the name of the image.

I'm surprised it doesn't get broken if you rename. Oh! If you rename in Drive, you need to click the little "refresh" arrows inside the Drive Explorer on the Paperize side, this refreshes the database and changes the name of the image so it won't match anymore. (Please tell me if this isn't true!)