paperos-labs / feedback

Just a bug and ideas board
0 stars 0 forks source link

Investment Vehicle Package is still covering credit usage even though it's not selected to #155

Open danielandelin opened 2 years ago

danielandelin commented 2 years ago

image

To Recreate add the Investment Vehicle partner group to an account and do a workflow that is included in the investment vehicle package.

danielandelin commented 2 years ago

image

danielandelin commented 2 years ago

This is only happening on some accounts.

SHRoberts91 commented 2 years ago

Steps to reproduce:

  1. Make sure you're logged into services@savvi.legal
  2. go to https://staging.savvi.legal/c/41206968/workbench/9/6431/16980/task-view
  3. View attached_partners array from the GET /api/account_project/6431 payload.
  4. 'Investment Vehicle' partner is showing up when it shouldn't.
  5. Only partners whose connected partner_package have their partner_covers_credits marked true and and have this workflow included in that package should show up in that workflow's attached_partner pretty sure.
BrackCarmony commented 2 years ago

When we setup partners that granted either standard or advanced subscriptions, we set it to cover all the credit usage of that account.
So it seems that some accounts have a partner associated that is covering their credit usage.
If we want to change this behavior so that granting a subscription doesn't cover the credit usage we can.

wmerfalen commented 2 years ago

I have a PR open for this, but I'd like some eyes on this before I get it rebased into main

wmerfalen commented 2 years ago

@BrackCarmony @danielandelin currently my fix involves checking if 1) The partner is current 2) If that partner has partner_covers_credits

As per @SHRoberts91's mention on this issue, he said that we need to check if the partner's package actually covers the workflow. Is that something we need to code for? because what I have on staging right now does not check for specific packages being covered. It's just, if it covers credit it covers everything in this case.