GOPATH development mode will be removed from Go any day now. This PR makes the necessary adjustments to use module-aware mode instead. This also eliminates the need for govendor, which is obsolete.
The majority of changes come from running the commands below. NOTE: go mod init gets confused when vendor.json lists transitive dependency revisions, since they use the commit ID of the parent. Specifically, spew and difflib both used d77da356e56a7428ad25149ca77381849a6a5232 from testify. To make it do the right thing, I looked up the actual commit IDs of both packages and replaced them in vendor.json first.
go mod init github.com/papertrail/remote_syslog2
go mod tidy
rm -rf vendor
go mod vendor
Afterwards, I ran PACKAGE_VERSION=0.20 make to confirm that everything still tests and builds successfully. Also confirmed that the resulting vendor folder was identical, accounting for some minor differences between govendor and go mod vendor:
Anything with // +build ignore is omitted.
Excluded github.com/howbazaar/loggo/example, possibly because it was an unused package.
We could also consider dropping the vendor folder entirely, but it doesn't hurt to keep it for now. (And especially for this PR, makes it more obvious that nothing has changed.)
I was able to produce the same exact executables using by running make before and after this PR's changes (with a bit of wrangling), so I think we're in good shape here.
GOPATH development mode will be removed from Go any day now. This PR makes the necessary adjustments to use module-aware mode instead. This also eliminates the need for
govendor
, which is obsolete.The majority of changes come from running the commands below. NOTE:
go mod init
gets confused whenvendor.json
lists transitive dependency revisions, since they use the commit ID of the parent. Specifically,spew
anddifflib
both usedd77da356e56a7428ad25149ca77381849a6a5232
fromtestify
. To make it do the right thing, I looked up the actual commit IDs of both packages and replaced them invendor.json
first.Afterwards, I ran
PACKAGE_VERSION=0.20 make
to confirm that everything still tests and builds successfully. Also confirmed that the resulting vendor folder was identical, accounting for some minor differences betweengovendor
andgo mod vendor
:// +build ignore
is omitted.github.com/howbazaar/loggo/example
, possibly because it was an unused package..gitignore
ortravis.yml
https://github.com/golang/go/issues/33261We could also consider dropping the vendor folder entirely, but it doesn't hurt to keep it for now. (And especially for this PR, makes it more obvious that nothing has changed.)