search

paperwm / PaperWM

Tiled scrollable window management for Gnome Shell
GNU General Public License v3.0
3k stars 127 forks source link

Conflict with extension Space Bar #720

Open riesthorsten opened 10 months ago

riesthorsten commented 10 months ago

Describe the bug PaperWM overwrites the workspace names that Space Bar extension has set.

To Reproduce Steps to reproduce the behavior:

  1. Install PaperWM and Space Bar
  2. Enable Smart Workspace Names feature
  3. Try to manually rename the workspace in the Space Bar, or have it set them automatically
  4. Switch workspaces: the workispace names revert to the PaperWM setting

Expected behavior PaperWM should either let other extensions set workspace names or have an option to disable workspace name management.

System information: As there was not crash, this is probably not too useful. 


Distribution: Fedora Linux 39
GNOME Shell 45
Lythenas commented 10 months ago

Does the extension work correctly if you enable the gnome workspace indicator pill in the paperwm settings?

Also if you only want to rename the workspaces, you can also do that in the paperwm settings.

Other than that I'm not sure how much we can support the Space Bar extension. It also seems to manage workspaces to some extend which would probably conflict with paperwm.

riesthorsten commented 10 months ago

In general, both extensions work as designed. Just part of that design is that PaperWM is overwriting the workspace names that are set by the other extension.

This behavior also shows when the indicator pill is enabled in PaperWM.

I understand that PaperWM probably cannot coordiante with all other extensions. But it would be great if one could just switch off the workspace name management part. :)

Lythenas commented 10 months ago

I see. We can probably implement that as a setting. Disabling this line conditionally will probably work: https://github.com/paperwm/PaperWM/blob/release/tiling.js#L1363 Although that would lead to some inconsistency between the paperwm internal names and the gnome workspace names. So we probably also need to read/listen to the gnome workspace names if we disable name handling in paperwm.

jtaala commented 10 months ago

Never mind my last comment (which I deleted), that dconf setting is what we do when enabling the indicator pill in prefs.

Lythenas commented 9 months ago

Correct me if I'm wrong here, but in Gnome workspaces have no names only indices, right? So I'm a little confused how the names shown in Space Bar would change to our names. But in any case we would probably need to implement specific compatibility with this extension.

I took a quick look and this is the config they use to store the workspace names:

https://github.com/christopher-l/space-bar/blob/89a41492240de00a070f4d4cba93426ba75d90fe/src/schemas/org.gnome.shell.extensions.space-bar.gschema.xml#L3-L7

So we could probably just listen to changes in this property and update our workspace names accordingly.

At the moment I'm not interested in implementing this but we would probably accept a PR for this.