Open iitzrohan opened 3 months ago
I think we had similar issues with similar extensions that hide or move the topbar in the past. E.g. Fullscreen Avoider #707
Does this fix itself if you e.g. resize the window?
Does changeing the "Enable Window Position Bar" setting change anything about the situation?
Taking a quick look at the code, it uses this to hide the panel:
const HIDDEN_PANEL_HEIGHT = 0.01; // px (> 0 !)
//...
_hidePanel() {
Main.panel.ease({
duration: ANIMATION_TIME,
height: HIDDEN_PANEL_HEIGHT,
onComplete: () => {
Main.panel.opacity = 0;
Main.layoutManager._updateHotCorners();
},
});
}
It might be possible to add compatibility for this.
Yes, the window does fix itself after resizing.
const HIDDEN_PANEL_HEIGHT = 0.01; // px (> 0 !)
Ah, they're using panel.height instead of something like hide()
.
Generally we wouldn't address specific extension implementations/overrides given that's a different approach to how Gnome works. But it is a valid approach (and tbh, PaperWM used to use a similar approach for Gnome topbar hiding).
Anyways, a notify signal could be added on the height
property of panel
that could trigger a layout
on that space (which would re-adjust window sizes).
Describe the bug I am using the dock unroll extension and when the panel hides itself, the window doesn't take full space.
To Reproduce Steps to reproduce the behavior:
Expected behavior The window should take full screen height but it gets stuck in the same position
Screenshots If applicable, add screenshots to help explain your problem.
System information: Please provide system information:
if you installed PaperWM via extensions.gnome.org please open PaperWM settings and select the
About
tab (last tab) and click theCopy to Clipboard
button and paste the information below, or;if you installed via source code, please execute
./gather-system-info.sh
in you PaperWM clone and paste the information belowAdditional context I have also submitted this bug report to dock unroll extension https://github.com/fthx/dock-unroll/issues/1