search

paperxyz / js-sdk

Other
5 stars 9 forks source link

Wrong getPaperOriginUrl default value #176

Closed qruz-hq closed 9 months ago

qruz-hq commented 9 months ago

I'm guessing this was overlooked while migrating payment links to thirdweb domains.

The actual default Paper origin url is https://payments.thirdweb.com not https://withpaper.com.

This is preventing modals with message handlers to work properly and firing paymentSuccess and claimSuccessful events. In my opinion this is top priority

https://github.com/paperxyz/js-sdk/blob/5615875f9f624fa435be2f96619fa101da13af00/packages/sdk-common-utilities/src/constants/settings.ts#L15

qruz-hq commented 9 months ago

This PR should fix it https://github.com/paperxyz/js-sdk/pull/177

warengonzaga commented 9 months ago

Hey @gerrysaporito can you check this? Thanks!

ElasticBottle commented 9 months ago

Hey @qruz-hq you should be using the sdk in the thirdweb package, Thanks!

qruz-hq commented 9 months ago

Hey @qruz-hq you should be using the sdk in the thirdweb package, Thanks!

Does this mean this package is deprecated?

Edit: I checked the thirdweb sdk and there's no replacement for the "renderPaperCheckoutLink" fuction. I'll stick to this package and implemented my extra message listeners to get around this. Will update to thirdweb packages when it has the same feature.