papinet / papiNet-API

papiNet is a global paper, forest products and bioproducts industry e-Business initiative.
http://www.papinet.org/
Apache License 2.0
9 stars 3 forks source link

Party construct in version 3.0.0 #104

Closed larsolofsson closed 6 months ago

larsolofsson commented 6 months ago

I don't understand why there are multiple uuid:s possible for a party. Shouldn't papiNet have only one uuid for a party?

What impact would this current party construct have on master data for parties when having two party identifiers assigned by supplier and customer? Should master data be skipped completely for parties in papiNet API, i.e should property id: be removed?

My proposal is two properties id: (optional) and partyIdentifiers (required), if uuid would be kept. (partyIdentifier is required in master data for parties, version 2.0.0) supplierParty: type: object required:

Later papiNet API should also support globally unique party identifiers. How would these globally unique party identifiers be added to the party construct.

The following globally unique party identifiers are used in papinet XML. These party identifiers don't need an assignedBy, but a type needs to be specified.

patricekrakow commented 6 months ago

This is indeed a mistake: the id should not be a child of of partyIdentifiers[] but a (unique) sibling! I think that both id and partyIdentifiers MUST NOT be required:

I will correct all the parties as suggested, but without partyIdentifiers being required.

patricekrakow commented 6 months ago

Done, see commit 48cd98c.

patricekrakow commented 6 months ago

We closed this issue with @larsolofsson, @bengtwentus and @MrNordenberg.

WARNING: The commit above does not contain ALL corrections, they have been completed in the context of the issue #106.