ListOfSupplierOrders: in version 3.0.0

[larsolofsson]

1. numberOfLines: name? numberOfLineItems is used in ver. 2.0.0. Naming should be consistent. Name a bit confusing because both PurchaseOrderNumber and SalesOrderNumber exist and line Items of salesOrder might not be the same as for supplierOrder and purchaseOrder. Is it now clear that it is the numberOfLineItems of the supplierOrder only.

2. numberOfLines: optional? numberOfLineItems is mandatory in ListPurchaseOrders

3. supplierOrderStatus: optional? purchaseOrderStatus is required in ListPurchaseOrders

4. salesOrderNumber: is on purchaseOrderLineItem in ver. 2.00 Now in the header of the supplierOrder?

   6. purchaseOrderNumber is assigned by the customer. Is it then OK having customerParty as optional?

[larsolofsson]

Decisions on 2023-12-20

1. numberOfLines to be change to numberOfLineItems.
2. numberOfLineItems should be changed to required.
3. supplierOrderStatus should be changed to required.
4. salesOrderNumber: should be move to the supplierOrderLineItem
5. Ok to have customerParty as optional.

[patricekrakow]

1. Done in commit d12ef5a.

2. Done in commit d12ef5a.

3. Done in commit d12ef5a.

4. OK, that means that salesOrderNumber should be removed from ListOfSupplierOrders which contains only "header" information. The removal is done in commit d12ef5a. The move is done in commit bcda087: The salesOrderNumber is not required within supplierOrderLineItems, is it OK? What about the purchaseOrderNumber? Should it also be moved to the supplierOrderLineItems (in GetSupplierOrderById)? In addition to that, we might want to also consider the following properties:

   • salesOrderTimestamp
   • salesOrderStatus
   • salesOrderLineItemNumber
   • salesOrderLineItemStatus
   • purchaseOrderTimestamp
   • purchaseOrderStatus
   • purchaseOrderLineItemNumber
   • purchaseOrderLineItemStatus

5. No change.

[patricekrakow]

I should probably create a new issue to discuss further the remaining questions about the references to the sales order(s) and the purchase order(s) so we can close this issue with the commits containing all the changes we agreed on!

[patricekrakow]

Remaining actions/discussions are described in issue #121 and issue #122.

[patricekrakow]

2024-01-17, finally we should leave the purchaseOrderNumber at the HEADER level and remove the salesOrderNumber completely!

[patricekrakow]

1. The purchaseOrderNumber is within the ListOfSupplierOrders.supplierOrders[] (header-level).
2. The purchaseOrderNumber is within the GetSupplierOrderById (header-level).
3. The salesOrderNumber is still within the GetSupplierOrderById.supplierOrderLineItems[] (line-level). Let's remove it.

[patricekrakow]

Done in commit 56a0b2b.