search

papinet / papiNet-API

papiNet is a global paper, forest products and bioproducts industry e-Business initiative.
http://www.papinet.org/
Apache License 2.0
9 stars 3 forks source link

At least one identifier should be required for sellerProduct, version 3.0.0 #128

Open larsolofsson opened 5 months ago

larsolofsson commented 5 months ago

A sellerProduct can be identified by the following properties: id: gradeCode: partNumber:

In current schema all of them are optional. At least one of them should be required. I propose adding the following to sellerProduct: anyOf:

patricekrakow commented 5 months ago

Let's make a working prototype with https://json-everything.net/json-schema/. The structure will become quite complex, the sellerProduct already have an allOf[1].oneOf[] structure, this proposal will make it a allOf[0].anyOf[] + allOf[1].oneOf structure!

larsolofsson commented 5 months ago

Patrice,

Haven’t you read my comment on issue #128?

Kind regards

Lars

From: Patrice Krakow @.> Sent: Wednesday, 31 January 2024 08:51 To: papinet/papiNet-API @.> Cc: Lars Olofsson @.>; Author @.> Subject: Re: [papinet/papiNet-API] At least one identifier should be required for sellerProduct, version 3.0.0 (Issue #128)

Let's make a working prototype with https://json-everything.net/json-schema/. The structure will become quite complex, the sellerProduct already have an allOf[1].oneOf[] structure, this proposal will make it a allOf[0].anyOf[] + allOf[1].oneOf structure!

— Reply to this email directly, view it on GitHub https://github.com/papinet/papiNet-API/issues/128#issuecomment-1918565454 , or unsubscribe https://github.com/notifications/unsubscribe-auth/APAU5ROZ6RN5WOWBSSLUH33YRHZWFAVCNFSM6AAAAABCFVLRK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJYGU3DKNBVGQ . You are receiving this because you authored the thread. https://github.com/notifications/beacon/APAU5RKUIVS2RTX7LKA36ALYRHZWFA5CNFSM6AAAAABCFVLRK2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTSLL6E4.gif Message ID: @. @.> >

patricekrakow commented 4 months ago

Use a similar structure as in issue #129 .

patricekrakow commented 4 months ago

We should discuss the definition of the properties and start using the description to actually write down those definitions (previously captured in the PDF).

patricekrakow commented 2 months ago

We are now discussing the semantics and consequential structure in the issue #141.