search

papinet / papiNet-API

papiNet is a global paper, forest products and bioproducts industry e-Business initiative.
http://www.papinet.org/
Apache License 2.0
9 stars 3 forks source link

Use `integer` type for `...LineItemNumber` properties in version 2.0.0 and 3.0.0 #132

Closed larsolofsson closed 2 months ago

larsolofsson commented 4 months ago

Line Item Numbers in version 1.3.0 and papiNet XML is defined as type: integer minimum: 0

In version 2.0.0 and 3.0.0 it is changed to type: string minLength: 1

I think it is a mistake and it should be changed back to type: integer minimum: 0

patricekrakow commented 4 months ago

We, during papiNet CWG meeting, 2024-02-28 (Wed), decided to change the type of all ...LineItemNumber properties from string to integer. The minimum value MUST be 0 in order to support 0-based index, but we do not allow negative values.

globaltopmedia commented 4 months ago

Is it just me, but if you set minimum:0 you exclude negative values https://swagger.io/docs/specification/data-models/data-types/

patricekrakow commented 2 months ago

Done, see commit 4f7cb88.