Open larsolofsson opened 4 months ago
I will start with
The update of quantityContext
has been done, see commit c542665.
It is not possible to condition the enumeration values of quantityUom
based on quantityType
having a certain value.
Within the Paper
structure - which should be exactly the same within papiNet-API.yaml
, papiNet-API.Supplier-Order-PROPOSAL.yaml
, papiNet-API.Delivery-Note-PROPOSAL.yaml
, papiNet-API.Goods-Receipt-PROPOSAL.yaml
, papiNet-API.Delivery-Instruction-PROPOSAL.yaml
- we have 8 unitOfMeasure
which seems properly "restricted".
Then, we have the following unitOfMeasure
that might still need to be restricted:
GetDeliveryInstructionById.sequences[].deliveryLegs[].transport.units[].measurements.length.unitOfMeasure
GetDeliveryInstructionById.sequences[].deliveryLegs[].transport.units[].measurements.width.unitOfMeasure
GetDeliveryInstructionById.sequences[].deliveryLegs[].transport.units[].measurements.height.unitOfMeasure
GetDeliveryInstructionById.sequences[].deliveryLegs[].transport.units[].measurements.weight.unitOfMeasure
GetDeliveryInstructionById.sequences[].lines[].quantities[].unitOfMeasure
GetDeliveryInstructionById.sequences[].lines[].packages[].quantities[].unitOfMeasure
ListOfDeliveryNotes.deliveryNotes[].transport.units[].measurements.length.unitOfMeasure
ListOfDeliveryNotes.deliveryNotes[].transport.units[].measurements.width.unitOfMeasure
ListOfDeliveryNotes.deliveryNotes[].transport.units[].measurements.height.unitOfMeasure
ListOfDeliveryNotes.deliveryNotes[].transport.units[].measurements.weight.unitOfMeasure
GetDeliveryNoteById.transport.units[].measurements.length.unitOfMeasure
GetDeliveryNoteById.transport.units[].measurements.width.unitOfMeasure
GetDeliveryNoteById.transport.units[].measurements.height.unitOfMeasure
GetDeliveryNoteById.transport.units[].measurements.weight.unitOfMeasure
GetDeliveryNoteById.lineItems[].quantities[].unitOfMeasure
GetDeliveryNoteById.lineItems[].packages[].quantities[].unitOfMeasure
CreateGoodsReceipt.lineItems[].quantities[].unitOfMeasure
CreateGoodsReceipt.lineItems[].packages[].quantities[].unitOfMeasure
GetSupplierOrderById.transport.units[].measurements.length.unitOfMeasure
GetSupplierOrderById.transport.units[].measurements.width.unitOfMeasure
GetSupplierOrderById.transport.units[].measurements.height.unitOfMeasure
GetSupplierOrderById.transport.units[].measurements.weight.unitOfMeasure
GetSupplierOrderById.lineItems[].quantities[].unitOfMeasure
1 quantityContext: Enumerations Ordered and Confirmed should be removed.
Add enumerations Loaded, Planned and Shipped.
Loaded to be used when shipmentStatus is Loaded. Planned to be used when shipmentStatus is Planned. Shipped to be used when shipmentStatus is Departed. Shipped to be used when shipmentStatus is Arrived. Shipped to be used when shipmentStatus is Unloaded.
N.B. These changes of enumerations of quantityContext: apply also to packages.quantities
2 quantityUom: When quantityType: is Count then enumerations of quantityUom: should include all package types. Add enumeration ReelPackage Rename enumeration PalletUnit to Pallet to be the same name as in package type. Is enumeration Package needed? Used for ReelPackage in papiNet xml. Could maybe be used when an unspecified package type is specified in a quantityType: Count. I think enumerations Piece and ThousandPieces are not applicable to paper and pulp use cases.
N.B. Applicable enumerations of quantityUom: in packages are not completely the same as in deliveryNoteLineItems. For example, if package type is *Pallet then quantityType: Count value:1 quantityUom: Pallet is not applicable. I think that PackageType should be removed from enumerations of quantityUom: in packages. Should non applicable enumerations be removed as earlier agreed?