papinet / papiNet-API

papiNet is a global paper, forest products and bioproducts industry e-Business initiative.
http://www.papinet.org/
Apache License 2.0
9 stars 3 forks source link

GetDeliveryNoteById.deliveryNoteLineItems.quantities in version 3.0.0 #137

Open larsolofsson opened 4 months ago

larsolofsson commented 4 months ago

1 quantityContext: Enumerations Ordered and Confirmed should be removed.

Add enumerations Loaded, Planned and Shipped.

Loaded to be used when shipmentStatus is Loaded. Planned to be used when shipmentStatus is Planned. Shipped to be used when shipmentStatus is Departed. Shipped to be used when shipmentStatus is Arrived. Shipped to be used when shipmentStatus is Unloaded.

N.B. These changes of enumerations of quantityContext: apply also to packages.quantities

2 quantityUom: When quantityType: is Count then enumerations of quantityUom: should include all package types. Add enumeration ReelPackage Rename enumeration PalletUnit to Pallet to be the same name as in package type. Is enumeration Package needed? Used for ReelPackage in papiNet xml. Could maybe be used when an unspecified package type is specified in a quantityType: Count. I think enumerations Piece and ThousandPieces are not applicable to paper and pulp use cases.

N.B. Applicable enumerations of quantityUom: in packages are not completely the same as in deliveryNoteLineItems. For example, if package type is *Pallet then quantityType: Count value:1 quantityUom: Pallet is not applicable. I think that PackageType should be removed from enumerations of quantityUom: in packages. Should non applicable enumerations be removed as earlier agreed?

patricekrakow commented 3 months ago

I will start with

patricekrakow commented 2 months ago

The update of quantityContext has been done, see commit c542665.

It is not possible to condition the enumeration values of quantityUom based on quantityType having a certain value.

patricekrakow commented 2 months ago

Within the Paper structure - which should be exactly the same within papiNet-API.yaml, papiNet-API.Supplier-Order-PROPOSAL.yaml, papiNet-API.Delivery-Note-PROPOSAL.yaml, papiNet-API.Goods-Receipt-PROPOSAL.yaml, papiNet-API.Delivery-Instruction-PROPOSAL.yaml - we have 8 unitOfMeasure which seems properly "restricted".

Then, we have the following unitOfMeasure that might still need to be restricted: