papinet / papiNet-API

papiNet is a global paper, forest products and bioproducts industry e-Business initiative.
http://www.papinet.org/
Apache License 2.0
9 stars 3 forks source link

Missing `classification` within `sellerProduct` #154

Open patricekrakow opened 1 week ago

patricekrakow commented 1 week ago

We agreed (2024-06-19) on this simple structure

classification:
  type: object
  properties:
    type:
      type: string
      enum:
        - ExportHarmonisedSystemCode
        - ... # re-use `ClassificationCodeType [attribute]` enumeration
    value:
      type: string
      minLength: 1
patricekrakow commented 1 week ago

Done, see commit 492175d.

larsolofsson commented 1 day ago

We need to discuss this issue. Construct in papinet xml may not be correct. We should now just add enumerations needed for StoraEnso logistics, i.e. ExportHarmonisedSystemCode. The meaning of Import and Export Harmonised System Codes for a specific product is depending on the country of import and export because the customs tariff is added to the Harmonised System Codes developed by the WCO Should we add a property countryCode?

For later use, Classification might also need be an array and have a property assignedBy (Agency in xml) as well as more enumerations for type: