search

papinet / papiNet-API

papiNet is a global paper, forest products and bioproducts industry e-Business initiative.
http://www.papinet.org/
Apache License 2.0
9 stars 3 forks source link

Wrong property names in PurchaseOrder 2.0.0 #91

Closed larsolofsson closed 8 months ago

larsolofsson commented 8 months ago

supplierParty and sellerParty have wrong names in ListOfPurchaseOrders, CreatePurchaseOrder and GetPurchaseOrderById.

supplierToParty to be changed to supplierParty. sellerToParty to be changed to sellerParty.

patricekrakow commented 8 months ago

Strictly speaking we should make this change within a 3.0.0 version, changing property names is an incompatible change. However, this is clearly a typo and I do not think that anyone has already created an implementation based on the current 2.0.0, so I would suggest that we just push this change in the current 2.0.0.

patricekrakow commented 8 months ago

We will go for 2.0.0 as a quick pragmatic exception, we should avoid doing that in the future!

patricekrakow commented 8 months ago

Changes have been implemented in PR #96.