search

papinet / papiNet-API

papiNet is a global paper, forest products and bioproducts industry e-Business initiative.
http://www.papinet.org/
Apache License 2.0
9 stars 3 forks source link

Update latestAllowedDateTimeForChange in version 2.0.0 #92

Closed larsolofsson closed 5 months ago

larsolofsson commented 11 months ago

minLength=4 is missing in schema for latestAllowedDateTimeForChange.

A description is missing for what local time is supplied in latestAllowedDateTimeForChange as decided at papiNet API meeting on 13 September 2023.

patricekrakow commented 11 months ago

The "minLength": 4 is indeed missing, and I think it can be added directly to the 2.0.0 version. Someone who would have implemented 2.0.0 with a latestAllowedDateTimeForChange of less than 4 characters would be simply not correct. However, since we will have a 2.1.0 release for other changes, this change will be incorporated into 2.1.0. Regarding the location of the local time, we do have the generic rule 10:

The properties ending with the suffix "...DateTime" SHOULD contain a local date and time, in accordance with the ISO 8601 standard (and preferably using an explicit time zone offset) for which the location is defined by the business context.

In the case of latestAllowedDateTimeForChange, I would say that the "business context" is given by either the supplierParty property or the domain name.

patricekrakow commented 5 months ago

Done, see commit 08bbfa0.