Maintainer - Githubissues

Etn40ff commented 4 years ago

What is the status with papis-rofi? I might be willing to take care of it if you point me to the needed changes to bring it up to speed.

alejandrogallo commented 4 years ago

Hello @Etn40ff and thank your for your offer and interest. I was at some point the only one person maintaining it and I kept on updating it but since I don't use rofi anymore it is at the end a lot of work to think about so many different projects.

I think some minimal unit testing has to be done, juts to ensure that papis-rofi works with the version of papis that should work for, github integration ought to be enough for it.
For the rest, I don't think there is much to be done, other than someone looking after the issues and pull requests from time to time, the project should work already, at least for my taste and some other peoples taste I know are using the package.

So in my opinion, if the maintainer is using papis-rofi, it should not be too much work to maintain it.

If you're still interested I'll give you write rights to this repo.

Etn40ff commented 4 years ago

Hi @alejandrogallo, I'll be glad to take care of it. For the moment I am using it and I should be able to keep track of the issues and pull requests.

I know nothing about github integration so I am not sure that I know how to set up tests.

Of course a friendly nudge when you make some breaking change in rofi will be appreciated.

alejandrogallo commented 4 years ago

brilliant! Ok no worries, I'll set up the main infrastructure for the continuous integration later, when that's done I'll close this issue then, you're as of now the maintainer! Thanks again!

alejandrogallo commented 3 years ago

Sorry for the delay. So I set up the infrastructure for the tests, and fixed some issues with the picker. You find most information in .github/workflows/main.yml and the tests are in tests, from now on it would be cool that new fixes come together with a simple test case.

I'll update the pypi package, I'll see that we can push automatically pypi versions when you bump up the version in the __init__.py file.

Etn40ff commented 3 years ago

Great thanks! I am not constantly monitoring the development of papis (time is unfortunately in short supply here) so please give me a nudge any time there are breaking changes that needs to be addressed.

PS: papis-rofi and papis-dmenu seems quite similar (I stole some code from there yesterday) would it make sense to merge them?

papis / papis-rofi

Maintainer #4