Update codebase - Githubissues

papis / papis-zotero

Zotero compatibility layer for papis

GNU General Public License v3.0

75 stars 17 forks source link

Update codebase #18

Closed alexfikl closed 1 year ago

alexfikl commented 1 year ago

The commits are fairly atomic, but this mostly:

adds and fixes more flake8 checks
adds mypy and type annotations.
updates the readme a bit
other small updates throughout the code.

I plan to make some more pull requests after this to add more tests and makes sure everything works with the latest Zotero.

alexfikl commented 1 year ago

@alejandrogallo I don't have access to this repo, so can't merge this. What do you think about getting it in?

The diff is a bit big because there's a lot of flake8 and mypy fixes in there, but otherwise only 3ec7ee3 has some proper changes (I can make a new PR for that if you want)

alejandrogallo commented 1 year ago

Hi alex! Thanks so much for these most needed updates, I just added you to the zotero team, feel free to do as you deem fit!

alejandrogallo commented 1 year ago

Should I then update to v0.2?

alexfikl commented 1 year ago

Hi alex! Thanks so much for these most needed updates, I just added you to the zotero team, feel free to do as you deem fit!

Awesome! Thank you very much! I'll give it another look and merge it :rocket:

It doesn't have any new features or bumped dependencies or anything, so I don't think a new release is necessary. I'll look through the bug reports a bit and try to add some more tests, as time permits, and ping you for a release later :grin: