search

papyri / idp.data

Data from the Integrating Digital Papyrology project
62 stars 36 forks source link

Corrected empty origPlace elements #395

Closed enury closed 6 months ago

enury commented 6 months ago

I have added the content of the placeName(s) in provenance element into origPlace, following the model I could deduce from the data:

Some documents did not have a provenance element. For the P.Gen. I could check the online catalogue and they were all of unknown provenance. I have assumed the same for a few others (p.schoyen, p.poethke) and I have added "Ägypten" for 129779 and 129769 because it was the provenance mentioned in the ÖNB catalogue.

I have not corrected 4145 and 5323 because they exist in parallel to identifiers with letters ( 4145a/b/c and 5323a/b), so I am not sure if these two should not be removed altogether...

For 75206 and 75234 in particular I am not sure about the correction. I could not see the @type "ancientFindspot" in the dropdown menus available in the Papyrological Editor, but I let it as it was in the data already.

jcowey commented 6 months ago

Fantastic. Exactly what was required and you did it through a pull request. I could not have asked for more. Thank you. By all means use such pull requests for anything else you might notice. I have checked the changes. In future if I noticed things that I would like to have done differently then I would use this comment function to ask for the tweaks.