papyri / sosol

The Son of Suda On Line
GNU General Public License v3.0
15 stars 13 forks source link

https => http on commit #345

Open jcowey opened 1 year ago

jcowey commented 1 year ago

Goodness knows why I have not noticed this before. Take this commit on finalization from the editor:

https://github.com/papyri/idp.data/commit/544c6a92ebe81f5f56cefcd7aa36544b69b7c823

Looking at lines 2, 34-43 one can see how https://... has been changed to http://... That should not be happening, because we want https:// throughout (Hugh carried out a massive global change https://github.com/papyri/idp.data/blob/master/DDB_EpiDoc_XML/bgu/bgu.4/bgu.4.1059.xml#L2 not so long ago: https://github.com/papyri/idp.data/commit/63dcc3112109dacbd90dde7f4e96b079af3b9499).

So I think a tweak to the SoSOL code is required.

An aside: look at https://github.com/papyri/idp.data/blob/master/DDB_EpiDoc_XML/bgu/bgu.4/bgu.4.1059.xml#L2:

<?xml-model href="https://epidoc.stoa.org/schema/8.16/tei-epidoc.rng" type="application/xml" schematypens="http://relaxng.org/ns/structure/1.0"?>

That does not make sense to me if I look at https://github.com/papyri/idp.data/commit/544c6a92ebe81f5f56cefcd7aa36544b69b7c823

- <?xml-model href="https://epidoc.stoa.org/schema/8.16/tei-epidoc.rng" type="application/xml" schematypens="http://relaxng.org/ns/structure/1.0"?>
+ <?xml-model href="http://www.stoa.org/epidoc/schema/8.16/tei-epidoc.rng" type="application/xml" schematypens="http://relaxng.org/ns/structure/1.0"?>

There, a rule seems to be overriding (correctly !! because https:// remains) the commit report.