search

papyros / qml-extras

OBSOLETE - SEE QML-MATERIAL REPOSITORY
https://github.com/papyros/qml-material
63 stars 22 forks source link

Restructure the extras into a Quantum.Extras module #2

Closed geiseri closed 9 years ago

geiseri commented 9 years ago

1) Changed license from GPL to LGPL. 2) Move the resources into a component structure. 3) Added .pro file to allow for component installation. 4) Added small set of tests to verify changes did not impact operation. 5) Started adding to the README to give some deeper examples.

geiseri commented 9 years ago

This is pretty invasive because I put everything into its own component. Let me know what you think.

iBelieve commented 9 years ago

Wow, you even added a couple tests and an example, that's great! One thing though - I don't want to name it Quantum, because the project is Quantum OS and I don't want confusion with any other projects named just Quantum, and also because it can be used on Windows or OS X, not just Quantum OS. I was thinking Material.Extras, but am open to other suggestions.

geiseri commented 9 years ago

How tightly bound are these to Material or Quantum? I have no problem with the Material namespace, but then I would argue that this should be contained inside of the qml-material project so that it is easier for packagers to manage dependencies. (I deal ALOT with packages, so I am biased to this sort of thing)

iBelieve commented 9 years ago

It's no way bound to Quantum OS or Material Design. I used a lot of these files on an Ubuntu Touch project. At the same time I agree that it's easier if it's part of one package. I don't care for distros that have several packages closely related to one another.

geiseri commented 9 years ago

It is just that Extras is a poor toplevel name, but I think Material.Extras might imply its bound to Material. If this is not an issue from your point of view I have no problem calling it Material.Extras though.

geiseri commented 9 years ago

@iBeliever any further thoughts on this? I renamed the namespace, but I also added a few more tests.

iBelieve commented 9 years ago

Sorry, was off for Thanksgiving yesterday. Material.Extras is not ideal, but let's go with that for now. Thanks for your work on this!