papyrus-mc / papyruscs

PapyrusCS renders maps of Minecraft: Bedrock Edition worlds using C#, LevelDB and leaflet.
Apache License 2.0
255 stars 42 forks source link

Black in recent player areas #101

Open STZobrist opened 2 years ago

STZobrist commented 2 years ago

Running on Bedrock 1.18.10 world, using latest papyruscs version 0.5.1-win64. Also updated texture folder.

It runs and completes without any errors, says map generated successfully.

Looking at the map there are black "specks" scattered throughout. Looking at them they actually appear to coincide with areas a player has recently been in the world, to the point where you can actually trace a player's path through the map. So despite those places having been explored/generated, they are appearing black (they did not previously when generating a map).

See attached example. Most of those black areas should be showing, and that path you can kinda see winding around is actually a player's path through the world. These areas were all generating just fine prior to this.

Example
chrisl8 commented 2 years ago

The current code will drop entire chunks if any one block in the chunk fails to render for various reasons, so my guess is that there is something new that is getting set when a player hits these chunks, and the code runs into them.

I made a pull request #97 that changes this behavior, but it hasn't been merged yet. It might solve your problem here, and it also might generate an error message that makes it easier to tell what has changed that is causing this.

I'm not sure if the author intends to merge my changes or not. There may be some good reason for rejecting them, but it has allowed me to render my dodgy worlds without problems.

STZobrist commented 2 years ago

Tried this PR (https://github.com/papyrus-mc/papyruscs/pull/97) and it works! Thank you so much!