search

papyrussolution / OpenPapyrus

Sophisticated ERP, CRM, Point-Of-Sale, etc. Open source now. This system is developed since 1996.
http://www.petroglif.ru
Other
237 stars 65 forks source link

reserved identifier violation #4

Open elfring opened 5 years ago

elfring commented 5 years ago

I would like to point out that identifiers like “__PPMENU_H” and “__TV_H” do not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

papyrussolution commented 5 years ago

This pratice has been used by as since 90th last century. It's hard to change this tradition :)

elfring commented 5 years ago

How do you think about to avoid that this software depends on undefined behaviour?

papyrussolution commented 5 years ago

We use a double-underscore. I don't think it can cause some problems (i consider such a propability as very low). Nevertheless, i gratitude you, because i didn't know about that considaration (depends on undefined behaviour).

elfring commented 5 years ago

Can any misplaced underscores be deleted in affected identifiers?

ugintl commented 1 year ago

@elfring Can you please answer this https://github.com/papyrussolution/OpenPapyrus/issues/11