[Proposal] StaticData needs region in Request

paquettg / leaguewrap

League of Legend API wrapper

MIT License

68 stars 28 forks source link

[Proposal] StaticData needs region in Request #121

Closed alabama closed 8 years ago

alabama commented 8 years ago

described here: https://github.com/paquettg/leaguewrap/issues/120

coveralls commented 8 years ago

Coverage decreased (-6.7%) to 88.837% when pulling 4e800ae88677329f114cdcfddeae2af9a08e3079 on alabama:master into 95ceca6ebecd2f08c909c8ce4a779684c074559d on paquettg:master.

alabama commented 8 years ago

-.- ok some more testcases are affected of this change

coveralls commented 8 years ago

Coverage remained the same at 95.51% when pulling b34a59a9bc2f36410a37faf6678fd7eed0a081e3 on alabama:master into 95ceca6ebecd2f08c909c8ce4a779684c074559d on paquettg:master.

dnlbauer commented 8 years ago

looks fine :+1: