search

paquettg / leaguewrap

League of Legend API wrapper
MIT License
67 stars 28 forks source link

API version #26

Closed jenssegers closed 10 years ago

jenssegers commented 10 years ago

Why is this API using version 1.3? Should it not be updated to a more recent version?

dnlbauer commented 10 years ago

What part of the api are you referring to?

jenssegers commented 10 years ago

The League of Legends API, the 2.2 version has more information than 1.3.

jenssegers commented 10 years ago

Oh I see, different endpoints have different version. I was referring to the match history one.

dnlbauer commented 10 years ago

Match history endpoint has the correct api version (which is 2.2). Maybe you mistake it with the game api which has a different endpoint.

At the moment there is game-1.3 which returns an overview of the last 10 played games AND matchhistory-2.2 which returns a more detailed overview but only returns ranked games.

jenssegers commented 10 years ago

Their documentation is a bit unclear, it does not really mention that matchhistory only returns ranked games. Too bad, because it seems that it contains more detailed information.

dnlbauer commented 10 years ago

According to some redposts on this thread (https://developer.riotgames.com/discussion/riot-games-api/show/XvQsMryF), normal games might be added to the matchhistory endpoint at a later time. :)

dnlbauer commented 10 years ago

Additionally, If you want those detailed informations for normal games, you can use the gameId from the game api and make a call to the mach api with that ID. Just be sure to not work against the obfuscation mentioned in the thread posted above.