search

paquettg / leaguewrap

League of Legend API wrapper
MIT License
67 stars 28 forks source link

Invalid rate limit calculation #38

Closed dnlbauer closed 10 years ago

dnlbauer commented 10 years ago

The current implementation of rate limit sums up all api calls from every region. In contrast, real rate limits are region dependent.

For example, with a rate limit of 10 requests/s, you can do 10 requests to NA and 10 requests to EUW at the same time without hitting the limit.

paquettg commented 10 years ago

Ya, this will need a complete change of the limit interface and limit object. This means that the change will not be backwards compatible so this change will be set for 0.6.0 which I have failed to put any time in.

I can't find the post for this change on the forums. Is it applied immediately or is it applied in a few months?

dnlbauer commented 10 years ago

This was already applied a long time ago but there was no post about it (I think they changed it with the release of region dependent base urls).

I recently saw this mentioned in their forums by a user and it seems to be true from testing with a dev key.