search

paracrawl / Domain_Adaptation

InDomain detection is a tool designed to extract in-domain data from a large collections of data.
GNU General Public License v3.0
1 stars 1 forks source link

Config file default doesn't make sense outside Omniscien #16

Closed kpu closed 5 years ago

kpu commented 5 years ago

The default config file is a bunch of custom paths that only exist at Omniscien and are useless to general users. Why is it optional? Reading sequentially from the beginning, the user is not aware of this problem until near the end.

The config file is really more of system setup with paths where tools are installed. Perhaps the install instructions should say to create such a config file: https://github.com/paracrawl/Domain_Adaptation/blob/master/INSTALL.md

amirkamran commented 5 years ago

Also the config file is not loaded in the code as key:value pairs. It is being loaded as ordered list.

dionwiggins commented 5 years ago

Resolved by most recent updates.