search

paracrawl / Domain_Adaptation

InDomain detection is a tool designed to extract in-domain data from a large collections of data.
GNU General Public License v3.0
1 stars 1 forks source link

Why catch an informative exception to throw a generic one? #28

Closed kpu closed 5 years ago

kpu commented 5 years ago

https://github.com/paracrawl/Domain_Adaptation/blob/432916d54f537342bcffb30f4968c2e19a5be98e/scripts/FullProcess.py#L92 Just makes it harder to know what the error is.

dalisola commented 5 years ago

You are right (even the error is catched from the previous checking ), I commit again and the errors goes to stderr.Thank you