paracrawl / Domain_Adaptation

InDomain detection is a tool designed to extract in-domain data from a large collections of data.
GNU General Public License v3.0
1 stars 1 forks source link

Be more flexible about python version #8

Closed kpu closed 5 years ago

kpu commented 5 years ago

Don't assume everybody has Python 3.6 installed. They might have 3.7 and no 3.6. Currently the code calls python3.6.

dionwiggins commented 5 years ago

Addressed in the latest code.

kpu commented 5 years ago

https://github.com/paracrawl/Domain_Adaptation/blob/cbd4c9109fff2e4a3978f84165df4552b67b1810/lib/FullProcess.py#L79

amirkamran commented 5 years ago

Also, in the requirements.txt there is logging dependency that does not compile for with pip3. Isn't logging library by default part of python3.

dalisola commented 5 years ago

Its work now with python3 no need for logging