search

paradedb / charts

ParadeDB Helm Chart, based on the official CloudNativePG Helm Charts
https://paradedb.github.io/charts/
GNU Affero General Public License v3.0
3 stars 2 forks source link

Unable to use existing secrets #2

Closed MuhanedYahya closed 1 month ago

MuhanedYahya commented 2 months ago

Bug Description When appUserCredentials and superUserCredentials are provided via values.yaml, new secrets are created during deployment. If these secrets already exist, the deployment fails with an error. This issue prevents the deployment of Paradedb in environments where sealed-secrets are used, as it cannot handle pre-existing secrets.

Proposed Fix add option like (existingSecret: SECRET_ NAME) under both of the sections appUserCredentials and superUserCredentials without the need to enter other values

After the correction I expect:

auth:
  appUserCredentials:
    existingSecret: app-user-secret
    # name: 
    # # Password for the app user (base64 encoded).
    # password: 
    # # Username for the app user (base64 encoded)
    # username: 

  superUserCredentials:
    existingSecret: super-user-secret
    # name: 
    # # Password for the superuser (base64 encoded).
    # password: 
    # # Username for the superuser (base64 encoded)
    # username: 

  # backupCredentials:
  #   existingSecret: backup-secret
  #   name: 
  #   # AWS ACCESS_KEY_ID (base64 encoded)
  #   accessKeyId: 
  #   # AWS ACCESS_SECRET_KEY (base64 encoded)
  #   accessSecretKey:
philippemnoel commented 2 months ago

Thank you for opening this. @itay-grudev is currently working on our Charts to revamp them. I've flagged this to him to make sure it is tested

itay-grudev commented 2 months ago

No worries, I'll include it in the test suite.

MuhanedYahya commented 1 month ago

Will this fix be ready in 2 weeks?

philippemnoel commented 1 month ago

Will this fix be ready in 2 weeks?

Yes, it should be. What is your use case/organization?

philippemnoel commented 1 month ago

Hi @MuhanedYahya. We are moving to https://github.com/paradedb/charts, which is based on the official CloudNativePG Charts, with help from @itay-grudev.

This is supported in those charts. ParadeDB support will be released for it within the week

MuhanedYahya commented 1 month ago

Nice to hear that. Honestly, I can’t share too much about the intended use, but you can check my profile to get a general sense of my background. https://www.linkedin.com/in/muhaned-yahya