Integrate sqllogictest

[Weijun-H]

What feature are you requesting?

Integrate SQLLogicTest to streamline FDW testing:

• Provides a simple, declarative syntax for SQL test cases
• Supports complex query verification
• Enables easy test case addition and maintenance

Why are you requesting this feature?

While working on #132, I encountered difficulties writing tests related to Foreign Data Wrappers (FDW). The current test suite contains significant code duplication for table initialization, making it cumbersome to add new tests. This feature could benefit pg_search and pg_analytics.

What is your proposed implementation for this feature?

After some consideration, it would be more effective to break down this issue into smaller tasks.

• [ ] Use the workspace feature of Cargo to include sqllogictests and pg_analytics two packages #147
• [ ] Integrate sqllogictest and convert some existing tests to sqllogoctests

Full Name:

Weijun Huang

Affiliation:

Individual

[Weijun-H]

If this ticket sounds good to you, I could try to work on it.

[philippemnoel]

If this ticket sounds good to you, I could try to work on it.

That feature sounds very useful yes. If we can improve the way we write tests it would be great.

Where do you see it be most useful for pg_search?

[Weijun-H]

If this ticket sounds good to you, I could try to work on it.

That feature sounds very useful yes. If we can improve the way we write tests it would be great.

Where do you see it be most useful for pg_search?

Because this feature could change the existing most of tests to .slt not only pg_analytics but also pg_search. It makes tests more maintainable and serves as clear documentation. For pg_search, this approach would standardize the testing approach, potentially improve test execution speed, and make it easier to add comprehensive test cases in the long term.

[Weijun-H]

/take

[philippemnoel]

/take

@Weijun-H. I just reviewed #152. I am unclear on whether we want this. I would suggest you make a very small sqllogictest for pg_search and PR it in that repo. The rest of the team can weigh in. Based on what they say, we can decide whether to do it here/there.

[philippemnoel]

@Weijun-H. We moved all our tests in a separate crate in paradedb/paradedb. I guess we could do the same here. Imitating the same approach would be optimal

[Weijun-H]

@Weijun-H. We moved all our tests in a separate crate in paradedb/paradedb. I guess we could do the same here. Imitating the same approach would be optimal

I think that deserves a separate ticket https://github.com/paradedb/pg_analytics/issues/160

[philippemnoel]

At this time, we've decided this is not a priority.