paradigms-of-intelligence / cubff

Apache License 2.0
111 stars 25 forks source link

fix: make CUDA=0 PYTHON=1 compilation work. fix typo. #2

Closed robryk closed 4 months ago

robryk commented 4 months ago

We need to build with -fPIC due to the Python .so we want to build, even if building not for CUDA.

Use ${FLAGS} instead of ${COMPILE_FLAGS} for the linking step (otherwise the useless-in-context -x cpp is provided and clang actually validly complains about it being useless).