search

paradigmxyz / reth

Modular, contributor-friendly and blazing-fast implementation of the Ethereum protocol, in Rust
https://reth.rs/
Apache License 2.0
3.87k stars 1.12k forks source link

extend txpool remove_txs utility #11684

Open mattsse opened 3 hours ago

mattsse commented 3 hours ago

Describe the feature

this isn't used by any component but is a nice utility:

https://github.com/paradigmxyz/reth/blob/43fe46f0d340fdf27e6b1b51916d0ecf9f6c314b/crates/transaction-pool/src/traits.rs#L294-L302

but I consider

https://github.com/paradigmxyz/reth/blob/43fe46f0d340fdf27e6b1b51916d0ecf9f6c314b/crates/transaction-pool/src/traits.rs#L296-L296

a footgun. there should be two functions for this behavior:

Additional context

No response

caglaryucekaya commented 2 hours ago

Hi, I'd like to work on this

caglaryucekaya commented 6 minutes ago

@mattsse I need some help here. It looks like the implementation of remove_transactions only removes the transactions with the given hashes, and no other dependent transactions. Am I missing something?