search

paradigmxyz / reth

Modular, contributor-friendly and blazing-fast implementation of the Ethereum protocol, in Rust
https://reth.rs/
Apache License 2.0
3.89k stars 1.13k forks source link

Move block traits to reth-primitivie-traits #11725

Closed mattsse closed 2 hours ago

mattsse commented 2 days ago

these files aren't even in use

https://github.com/paradigmxyz/reth/blob/9f9de0fab96712761944806120b1764cf1bee0eb/crates/primitives/src/traits/mod.rs#L1-L1

they should be moved to reth-primitive-traits

vandenbogart commented 2 days ago

I can take this as a first issue

vandenbogart commented 1 day ago

The Block and BlockBody traits have a number of dependencies on other types in reth-primitives. Adding that as a dependency to reth-primitives-traits creates a circular dependency. Is there a simple way to resolve this that I don't know about?

mattsse commented 1 day ago

hmm, good point, need to look into this first

Rjected commented 2 hours ago

Duplicate: https://github.com/paradigmxyz/reth/issues/11757 Solved by: https://github.com/paradigmxyz/reth/pull/11780