search

paradigmxyz / reth

Modular, contributor-friendly and blazing-fast implementation of the Ethereum protocol, in Rust
https://reth.rs/
Apache License 2.0
3.97k stars 1.2k forks source link

Copy `ImportCommand` to `ImportBedrockCommand` #12476

Closed emhane closed 3 days ago

emhane commented 5 days ago

Describe the feature

Copy ImportCommand command into a new reth-optimism-cli command ImportBedrockCommand. This is needed so a different codec can be used. Possibly makes sense to decompose the code in reth_cli_commands::import into smaller functions that can be imported into reth-optimism-cli to minimise redundancy - but not a requirement since ImportBedrockCommand is intended for importing the ovm chain (in the past hence and won't be effected by new eips).

blocked by https://github.com/paradigmxyz/reth/issues/12475

Additional context

No response

emhane commented 5 days ago

would you like to continue with this @lean-apple ? it's possible to implement it using the BlockFileCodec, and then in a separate pr replace the codec when https://github.com/paradigmxyz/reth/issues/12475 is solved

lean-apple commented 5 days ago

Yeah sure ! :)

emhane commented 3 days ago

sorry @lean-apple , I saw this already exists