search

paradigmxyz / reth

Modular, contributor-friendly and blazing-fast implementation of the Ethereum protocol, in Rust
https://reth.rs/
Apache License 2.0
3.99k stars 1.22k forks source link

fix: do not delegate is_optimism check for Ethereum ChainSpec #12650

Closed fgimenez closed 3 days ago

fgimenez commented 3 days ago

is_optimism should always be false for Ethereum's ChainSpec, otherwise it could return true for an Ethereum chain spec if the chain id is one of Optimism's chains.

This was causing hive tests to fail https://github.com/paradigmxyz/reth/actions/runs/11903470318/job/33171134482 will retrigger on this branch.

fgimenez commented 3 days ago

Successful hive execution from this branch https://github.com/paradigmxyz/reth/actions/runs/11910257420