search

paradigmxyz / reth

Modular, contributor-friendly and blazing-fast implementation of the Ethereum protocol, in Rust
https://reth.rs/
Apache License 2.0
3.99k stars 1.21k forks source link

fix: use `body.recover_signers_unchecked` instead on `try_with_senders_unchecked` #12668

Closed joshieDo closed 2 days ago

joshieDo commented 2 days ago

alternative to https://github.com/paradigmxyz/reth/pull/12666

Block::try_with_senders_unchecked was not using an unchecked recovery method

alessandromazza98 commented 2 days ago

I'm checking if this fixes my problem, again thanks a lot for being so fast to reply. will update here shortly

alessandromazza98 commented 2 days ago

with this PR I still have the same problem, with my (https://github.com/paradigmxyz/reth/pull/12666) PR i don't have it

joshieDo commented 2 days ago

SealedBlock which is used in this request actually needed to be changed as well (not just Block). Can you try again?

Tbh, I'm still unsure on what causes the issue. It should not matter if it's unchecked or not, since TxDeposit are "caught" on : https://github.com/paradigmxyz/reth/blob/02a90e1c0b48c0af5842b92a49860e8446b5a0e2/crates/primitives/src/transaction/mod.rs#L892-L902

joshieDo commented 2 days ago

merging since this still makes sense on its own

alessandromazza98 commented 2 days ago

SealedBlock which is used in this request actually needed to be changed as well (not just Block). Can you try again?

Tbh, I'm still unsure on what causes the issue. It should not matter if it's unchecked or not, since TxDeposit are "caught" on :

https://github.com/paradigmxyz/reth/blob/02a90e1c0b48c0af5842b92a49860e8446b5a0e2/crates/primitives/src/transaction/mod.rs#L892-L902

tried but still same error. I'm going to investigate a bit more why I have this error, thanks