chore(sdk): define helper trait `BlockPrimitives`

[emhane]

Based on https://github.com/paradigmxyz/reth/pull/12647

• Defines helper trait BlockPrimitives, which links NodePrimitives::Block to NodePrimitives::BlockHeader, NodePrimitives::BlockBody and NodePrimitives::SignedTransaction. This makes the trait bounds necessary on impl bodies much less verbose!
• Makes NodePrimitives super trait of FullNodePrimitives, as it allows for the transition FullNodePrimitives -> BlockPrimitives -> NodePrimitives. NOTE: the reason I didn't do this in the first place is because I copied the pattern of FullNodeComponents -> RpcNodeCore used to simplify type definitions, introduced because FullNodeComponents wasn't built from a base trait without trait bounds (and re-writing that would have been a too big change for the task). Here we have the opportunity to have a plain (trait unbound) super trait though since we're writing primitives from scratch.

[klkvr]

• Fixes bug in stages. Bug: writing compact encoded signed transaction instead of the unsigned transaction to db

I believe we've been always writing signed transaction to both static files and database? https://github.com/paradigmxyz/reth/blob/166a2346dcd2a9c8d5fea6995a9fc5e6426c62bb/crates/storage/provider/src/providers/static_file/writer.rs#L543-L547 https://github.com/paradigmxyz/reth/blob/166a2346dcd2a9c8d5fea6995a9fc5e6426c62bb/crates/storage/db/src/tables/mod.rs#L295

[emhane]

• Fixes bug in stages. Bug: writing compact encoded signed transaction instead of the unsigned transaction to db

I believe we've been always writing signed transaction to both static files and database?

https://github.com/paradigmxyz/reth/blob/166a2346dcd2a9c8d5fea6995a9fc5e6426c62bb/crates/storage/provider/src/providers/static_file/writer.rs#L543-L547

https://github.com/paradigmxyz/reth/blob/166a2346dcd2a9c8d5fea6995a9fc5e6426c62bb/crates/storage/db/src/tables/mod.rs#L295

TransactionSigned doesn't impl Compact though

[klkvr]

It does since https://github.com/paradigmxyz/reth/pull/12539

related discussion https://github.com/paradigmxyz/reth/pull/12694#discussion_r1851075736

[emhane]

then it should impl Compact, but it doesn't. before StaticFileProviderRW::append_transaction took TransactionSignedNoHash. @klkvr

[klkvr]

then it should impl Compact, but it doesn't

It does impl Compact https://github.com/paradigmxyz/reth/blob/e3702cfc87449294da061f02a571a23061b8ab50/crates/primitives/src/transaction/mod.rs#L1054

before StaticFileProviderRW::append_transaction took TransactionSignedNoHash

yep, but now it takes anything that implements Compact (should probably change that to N::SignedTx given that we have primitives on StaticFileProvider now)

sorry for the confusion with the 2 storage types, I was expecting the TransactionSignedNoHash to be gone by now

[emhane]

ok nvm, switching between a lot of branches to shrink scope, my bad

[emhane]

re-request review @klkvr