search

paradigmxyz / reth

Modular, contributor-friendly and blazing-fast implementation of the Ethereum protocol, in Rust
https://reth.rs/
Apache License 2.0
3.99k stars 1.21k forks source link

Inherit header type in `BlockchainProvider2` impl #12753

Open emhane opened 11 hours ago

emhane commented 11 hours ago

Describe the feature

Replace concrete type Header/SealedHeader with reth_node_types::HeaderTy<N> in impl of BlockchainProvider2 where possible. https://github.com/paradigmxyz/reth/blob/f8d683e80ee08412e19cc212a4c2bf8ebeca245b/crates/storage/provider/src/providers/blockchain_provider.rs#L47-L756

To do this, probably the generic N on BlockchainProvider2's type definition, will have to be passed to CanonicalInMemoryState first. https://github.com/paradigmxyz/reth/blob/f8d683e80ee08412e19cc212a4c2bf8ebeca245b/crates/storage/provider/src/providers/blockchain_provider.rs#L58

Additional context

No response

emhane commented 11 hours ago

blocked by https://github.com/paradigmxyz/reth/pull/12723

lakshya-sky commented 6 hours ago

can I take this?