perf tracing: make log recording optional - Githubissues

paradigmxyz / reth

Modular, contributor-friendly and blazing-fast implementation of the Ethereum protocol, in Rust

https://reth.rs/

Apache License 2.0

3.96k stars 1.19k forks source link

perf tracing: make log recording optional #3268

Closed mattsse closed 1 year ago

mattsse commented 1 year ago

Describe the feature

most tracers don't need logs that we record here (currently only CallTracer if includeLogs is enabled):

https://github.com/paradigmxyz/reth/blob/c75cacf85551f9d6ccbdfddf5530541b6da7658e/crates/revm/revm-inspectors/src/tracing/mod.rs#L328-L341

TODO

add config value for record_logs: https://github.com/paradigmxyz/reth/blob/c75cacf85551f9d6ccbdfddf5530541b6da7658e/crates/revm/revm-inspectors/src/tracing/config.rs#L7-L10
only record logs if record_logs is true

Additional context

No response

tcoratger commented 1 year ago

I think this one is closed by #3286 or does it require other elements?