search

paradigmxyz / reth

Modular, contributor-friendly and blazing-fast implementation of the Ethereum protocol, in Rust
https://reth.rs/
Apache License 2.0
3.85k stars 1.1k forks source link

Plug in discv5 & rlpx hive tests #6159

Open emhane opened 8 months ago

emhane commented 8 months ago

Describe the feature

discv5 has now been added to hive and rlpx tests have been updated to post-merge! ci should be updated to include these.

Additional context

No response

### Tasks
- [ ] https://github.com/paradigmxyz/reth/issues/6504
- [ ] https://github.com/paradigmxyz/reth/issues/6506
Rjected commented 8 months ago

We should be running rlpx tests now, for discv5 we would just need to add discv5 here: https://github.com/paradigmxyz/reth/blob/04d994fe22d99c3f2e6518fbc441a294df7eb692/.github/workflows/hive.yml#L66-L67

emhane commented 8 months ago

aha, found it, in hive rlpx tests are just called eth

emhane commented 8 months ago

seems like you last revised the eth tests in April last year though @Rjected, and the updates in the issue description were committed in December last year

Rjected commented 8 months ago

seems like you last revised the eth tests in April last year though @Rjected, and the updates in the issue description were committed in December last year

We pull changes from the main hive branch though, so any changes there should reflect in CI

emhane commented 7 months ago

from the diff in the linked geth pr, these tests are not run in reth's ci:

https://github.com/ethereum/go-ethereum/blob/f0c5b6765d1815a3c6a0cd1b2740607a8b5bb1f8/cmd/devp2p/internal/ethtest/suite.go#L81

https://github.com/ethereum/go-ethereum/blob/f0c5b6765d1815a3c6a0cd1b2740607a8b5bb1f8/cmd/devp2p/internal/ethtest/suite.go#L83

and these have been removed: https://github.com/paradigmxyz/reth/blob/84efe140633ab7fff69999b865dee002928af80e/.github/workflows/hive.yml#L83 https://github.com/paradigmxyz/reth/blob/84efe140633ab7fff69999b865dee002928af80e/.github/workflows/hive.yml#L72

looking closer at reth's ci, I also notice these test, that have been committed before that geth pr, aren't included either:

https://github.com/ethereum/go-ethereum/blob/f0c5b6765d1815a3c6a0cd1b2740607a8b5bb1f8/cmd/devp2p/internal/ethtest/suite.go#L79

https://github.com/ethereum/go-ethereum/blob/f0c5b6765d1815a3c6a0cd1b2740607a8b5bb1f8/cmd/devp2p/internal/ethtest/suite.go#L82

github-actions[bot] commented 7 months ago

This issue is stale because it has been open for 21 days with no activity.

github-actions[bot] commented 6 months ago

This issue was closed because it has been inactive for 7 days since being marked as stale.