search

paradigmxyz / reth

Modular, contributor-friendly and blazing-fast implementation of the Ethereum protocol, in Rust
https://reth.rs/
Apache License 2.0
3.94k stars 1.18k forks source link

Track bad `PooledTransactions` responses with metrics #6529

Open emhane opened 9 months ago

emhane commented 9 months ago

Describe the feature

Track peers that respond with other transactions than those requested.

Ultimately, this should include transactions that are not of the same size as the announced size, if eth68 metadata is known for the tx hash, since the announced size could be fake. However, the latter could be misleading so long as metadata is not stored as a (peer, size) tuple, https://github.com/paradigmxyz/reth/issues/6528, hence can be addressed at a later point.

Depends on https://github.com/paradigmxyz/reth/issues/6438.

Additional context

No response

### Tasks
- [ ] https://github.com/paradigmxyz/reth/pull/7401
Richa-iitr commented 8 months ago

Hey @emhane, can i take this up?

emhane commented 8 months ago

that would be great @Richa-iitr ! best use https://github.com/paradigmxyz/reth/pull/6439 as base branch and incorporate the logic for this issue into the PooledTransactions verification. just finished up the code in lib in my pr, just need to finish up fixing the tests target and lint, so shouldn't be much, if any, merge conflicts for you later.

Richa-iitr commented 8 months ago

Sure, thanks :)

github-actions[bot] commented 8 months ago

This issue is stale because it has been open for 21 days with no activity.

emhane commented 8 months ago

@Richa-iitr how's it going with this?

Richa-iitr commented 8 months ago

Hi, i was travelling for the last 2 weeks. Plan to look into this in this week. Hope this works?