Implement p2p related tools

[int88]

Describe the feature

There are some p2p related tools geth, like:

https://geth.ethereum.org/docs/tools/devp2p

https://github.com/ethereum/go-ethereum/tree/master/p2p/simulations

If it's meaningful to implement related tools in reth, I'd like to do it!

@mattsse @emhane WDTY?

Additional context

No response

[mattsse]

sgtm!

if you want, you can add these as standalone crates first

[int88]

devp2p command TODO list:

• enrump: Pretty-prints node records Impl missing in pr to https://github.com/agemanning/enr-cli
  • [ ] enrdump
• key: Operations on node keys Impl missing ones in pr to https://github.com/agemanning/enr-cli
  • [ ] generate: Generate node key files
  • [ ] to-id: Create a node ID from a node key file
  • [ ] to-encode: Creates an encode URL from a node key file
  • [ ] to-enr: Creates an ENR from a node key file
• discv4: Node Discovery v4 tools leave this out, since ethereum is moving towards discovery version 5, we keep discv4 for backwards compatibility, but no need to impl anything more for it
  • [ ] ping: Sends ping to a node
  • [ ] requestenr: Requests a node record using EIP-868 enrRequest
  • [ ] resolve: Finds a node in the DHT
  • [ ] resolve-json: Re-resolves node in a nodes.json file
  • [ ] crawl: Updates a nodes.json file with random nodes found in the DHT
  • [ ] test: Runs tests against a node
• discv5: Node Discovery v5 tools impl missing ones in pr to https://github.com/AgeManning/discv5-cli
  • [ ] ping: Sends ping to a node
  • [ ] resolve: Finds a node in the DHT
  • [ ] crawl: Updates a nodes.json file with random nodes found in the DHT
  • [ ] test: Runs test against a node
  • [ ] listen: Runs a node
• dns: DNS Discovery Commands extend existing p2p::Subcommands with new variant Dns, and impl each of these as sub-subcommands
  • [ ] sync: Download a DNS discovery tree
  • [ ] sign: Sign a DNS discovery tree
  • [ ] to-txt: Creates a DNS TXT records for a discovery tree
  • [ ] to-cloudflare: Deploy DNS TXT records to CloudFlare
  • [ ] to-route53: Deploy DNS TXT records to Amazon Route53
  • [ ] nuke-route53: Deletes DNS TXT records of a subdomain on Amazon Route53
• nodeset: Node set tools extend existing p2p::Subcommands with these
  • [ ] info: Show statistics about a node set
  • [ ] filter: Filters a node set
• rlpx: RLPx Commands extend existing p2p::Subcommands with new variant Rlpx, and impl each of these as sub-subcommands
  • [ ] ping: ping
  • [ ] eth-test: Runs eth protocol tests against a node
  • [ ] snap-test: Runs snap protocol tests against a node

[emhane]

for sure! really nice idea

[emhane]

I'd tackle each todo as a separate new issue, adding to task list here. that way it's easier for us to review, more overseeable to give you specific hints for impl in that issue, and less merge conflicts with main for you since each topic branch would be short-lived.

a hint for discv5 already, is to use this method https://github.com/paradigmxyz/reth/blob/ef3f67743d517b2b15692949efae4671168bccbd/crates/net/discv5/src/lib.rs#L381-L387 and then read the sigp Discv5 public api thoroughly, should be possible to impl all commands with those existing methods https://github.com/sigp/discv5/blob/master/src/discv5.rs

make sure to try this tool out first https://github.com/AgeManning/discv5-cli, no need to impl same thing again in reth imo @int88

[Rjected]

make sure to try this tool out first https://github.com/AgeManning/discv5-cli, no need to impl same thing again in reth imo

agree, as well as enr-cli: https://github.com/agemanning/enr-cli

cargo install makes using these really easy

[emhane]

agree, as well as enr-cli: https://github.com/agemanning/enr-cli

true this tool exists too

I updated your list @int88 based on review https://github.com/paradigmxyz/reth/pull/8403#pullrequestreview-2102458098 and https://github.com/paradigmxyz/reth/pull/8403#pullrequestreview-2102435753

[int88]

Thanks for all of your kind reviews @mattsse @Rjected @emhane .

So I would implement the commands filtered by @emhane .

One last concern, should these commands should be integrated into reth p2p or as a separate binary?

IMO, I agree with @Rjected , integrated into reth p2p maybe better :)

[emhane]

One last concern, should these commands should be integrated into reth p2p or as a separate binary?

yes, see the text I added to the list in bold @int88. check out how it is done for the db subcommand clear with subsubcommands mdbx and static-file

https://github.com/paradigmxyz/reth/blob/e0c22ace34e520b6276af2f54acb634363b7979f/bin/reth/src/commands/db/clear.rs#L13-L16

so for example, p2p would be the command, rlpx is a subcommand (like clear), and ping is a sub subcommand (like mdbx)