Closed mattsse closed 6 hours ago
can look at it
This issue is stale because it has been open for 21 days with no activity.
@mattsse which of these Eth*
and Exec*
types do you want to become generic? All of them?
impl PayloadTypes for EthEngineTypes {
type BuiltPayload = EthBuiltPayload;
type PayloadAttributes = EthPayloadAttributes;
type PayloadBuilderAttributes = EthPayloadBuilderAttributes;
}
impl EngineTypes for EthEngineTypes {
type ExecutionPayloadV1 = ExecutionPayloadV1;
type ExecutionPayloadV2 = ExecutionPayloadEnvelopeV2;
type ExecutionPayloadV3 = ExecutionPayloadEnvelopeV3;
type ExecutionPayloadV4 = ExecutionPayloadEnvelopeV4;
And I'm assuming you mean that EthEngineTypes
becomes generic and EngineTypes
and PayloadTypes
do not
If I have the capacity, I will try.
Hey @mattsse is this the right way to go? https://github.com/paradigmxyz/reth/pull/10779 thanks!
closing because this is no longer feasible
Describe the feature
currently the associated types for enginetypes are fixed
https://github.com/paradigmxyz/reth/blob/5100ddd28e3ae0396aa97633d6f700d77aefb50f/crates/ethereum/engine-primitives/src/lib.rs#L32-L38
which makes it harder to configure a custom payload/builder etc
we should make the relevant payload types generic here, this should happen after:
https://github.com/paradigmxyz/reth/issues/8330
Additional context
No response