enable rust.unnameable-types = "warn" lint

paradigmxyz / reth

Modular, contributor-friendly and blazing-fast implementation of the Ethereum protocol, in Rust

https://reth.rs/

Apache License 2.0

3.78k stars 1.02k forks source link

enable rust.unnameable-types = "warn" lint #9401

Open mattsse opened 1 month ago

mattsse commented 1 month ago

Describe the feature

TODO

add new lint: https://github.com/paradigmxyz/reth/blob/bb8ff671828b2ae9f2ab71edce6e1a1f01c2b649/Cargo.toml#L155-L155
fix warnings either by making types pub(crate) or exporting them (these fixes can be submitted as separate prs to make them easier to review)

Additional context

No response

kamuik16 commented 1 month ago

I can take this one.

kamuik16 commented 1 month ago

@mattsse this is a larger issue and wouldn't be feasible to do it in a single issue. Should we do it crate wise and then after all the crates we can add the lint to the root Cargo.toml?

also unassigning me if others want to contribute as I just compile with this lint and there are a lot of warnings.

mattsse commented 1 month ago

Should we do it crate wise

that sounds great!