paradigmxyz / reth

Modular, contributor-friendly and blazing-fast implementation of the Ethereum protocol, in Rust
https://reth.rs/
Apache License 2.0
3.78k stars 1.02k forks source link

remove transaction forwarder trait #9562

Closed mattsse closed 1 week ago

mattsse commented 1 month ago

Describe the feature

now that we have separate ethapi impls for op and eth, we no longer need this

https://github.com/paradigmxyz/reth/blob/fb6ea8b9249221cbbcc888f393bfc64f9a476d4e/crates/rpc/rpc-eth-api/src/helpers/transaction.rs#L651-L657

TODO

Additional context

No response

nkysg commented 1 month ago

May I take this?

EmmanuelAR commented 1 month ago

Hello @mattsse

My name is Emmanuel, a software developer from Costa Rica. I would be happy to assist with this task. I will review the current implementation and will guide by the comments that you post in the ticket

Please let me know if this is acceptable.

Best regards, Emmanuel 😁